Fix buildApprovals to accept privateKey parameter#688
Open
mk-dhia wants to merge 1 commit into
Open
Conversation
The buildApprovals function was defined with a single `authorizations` parameter, while every call site and the README passed `buildApprovals(privateKey, authorizations)`. The extra argument was silently dropped and `privateKey` inside the body was an undeclared free variable, so the example threw at runtime before signing any request. Add the missing `privateKey` parameter to match the call sites. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildApprovalsinexamples/authorizations.jswas defined with a singleauthorizationsparameter, but every call site (bidAuction.js,createSingleSaleOffer.js,acceptSingleSaleOffer.js) and the README passbuildApprovals(privateKey, authorizations).The extra
privateKeyargument was silently dropped, and theprivateKeyreferenced inside the function body was an undeclared free variable. Because these are ES modules (strict mode), running the example throwsReferenceError: privateKey is not definedbefore any authorization request is signed.Fixing the example code